Restructure device tracker #23862
Merged
Restructure device tracker #23862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| @callback | ||
| def async_setup_scanner_platform(hass: HomeAssistantType, config: ConfigType, |
There was a problem hiding this comment.
This is only for the legacy type, right? Should we move it to legacy?
MartinHjelmare
approved these changes
May 15, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
* Restructure device tracker * Docstyle * Fix typing * Lint * Lint * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Restructure the device tracker to make it easier to add EntityPlatform support.
This PR is a first step in an overhaul that will supersede the overhaul in #21151. The plan is to do #21151 but in smaller steps + make it that instead of overhauling everything at once, we will introduce it in a way that new platforms will use EntityPlatform, while the old ones remain using the legacy code.
Once the overhaul is complete, we will no longer accept contributions using the old style. Important platforms will be migrated to use the EntityPlatform.
Related issue (if applicable): home-assistant/architecture#151
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: